Helena

I guess should just implement all the custom features that I know, since you keep requesting this and that
better to overdo it and then let you suggest which feature you want me to take out,
rather than keep asking for more features each time
... of course if you got some other features that you want to suggest, you can always post here
http://upaste.me/fa2349922cf42b53b
I wanted to add the rejoin system like I did on arathi basin or this bg_emp_0.6
but it seems rathena cannot retrieve the instance variable outside of the instance npc,
so unless you want to drop the instancing and use normal map ...
EDIT: suddenly I think its possible ... every time a variable is set, push back as npc variable ... hmm ...

change this line 103
bg_get_data 'winside, 1; for ( .@i = 0; .@i < $@arenamemberscount; ++.@i ) getitem getvariableofnpc( .rewarditem[0], 'main$ ), getvariableofnpc( .rewarditem[1], 'main$ ), $@arenamembers[.@i]; into
bg_get_data 'winside, 1; for ( .@i = 0; .@i < $@arenamemberscount; ++.@i ) getitem 501, 10, $@arenamembers[.@i]; bg_get_data ('winside == 'red)? 'blue:'red, 1; for ( .@i = 0; .@i < $@arenamemberscount; ++.@i ) getitem 501, 5, $@arenamembers[.@i];  
btw rathena seems going to get rid of CSV format and going for YAML format
https://github.com/rathena/rathena/pull/3163
so just take note of this when instancing doesn't work

http://upaste.me/c7b7498104f6c72df
you know ... this script do exactly the same thing as the previous one ...
now you can see the script just look totally different
EDIT: although I don't know you are also obsess with instanced battleground or not ... since both hercules and rathena also can do it

hercules<=>rathena battleground/instance/mob-controller script commands are totally different
I also have to admit hercules one are always on the harder side
... this is not funny matter .... just ... well ... see how the script grow in size comparative to rathena ones,
and you'll understand why until today I still haven't convert my arathi basin on rathena into hercules
http://upaste.me/f08349808ea0ba1b1

2.4b http://upaste.me/0c8149627b3ddc0c6
- fix a typo in mission limitation can do daily or only once, actually allows to do twice instead of once
- fix a typo in mission time limit, if your mission no.2/3/4 has expired, the script always says slot no.1
@Helena
2.4c http://upaste.me/7c9c496344829d36f
- fix this f*cking deny usage once again ...this time when submit a mission, the getarraysize calculation is made AFTER declare the datetime format
- if the whole board is set to EVERYDAY, remove the player side deny usage variable completely on the next day

delitem(Blue_Potion, countitem(Blue_Potion));

Replace
.itemname$[ .@k ] = getitemname( .itemid[ .@k ] ); with
.itemname$[ .@k ] = (getitemname( .itemid[ .@k ] ) != "null")?getitemname( .itemid[ .@k ] ):""; That way nothing will be altered, client doesn't show empty options (""), but still counts them in when returning chosen index.

new_1-1,56,126,0 script Test 4W_SAILOR,{ if (!countitem(5172)) { mes "You don't have any "+ getitemname(5172); close; } getinventorylist; mes "Pick the refine rate of "+ getitemname(5172) +" that you want to trade..."; next; .@menu$ = ""; for (.@i = 0; .@i < @inventorylist_count; ++.@i) { if (@inventorylist_id[.@i] == 5172 && @inventorylist_identify[.@i] == 1) { // We Need Identified Item .@card = 0; if (@inventorylist_card1[.@i]) .@card++; if (@inventorylist_card2[.@i]) .@card++; if (@inventorylist_card3[.@i]) .@card++; if (@inventorylist_card4[.@i]) .@card++; // ~ +7 ItemName (x4 Cards) .@menu$ = .@menu$ +"~ +"+ @inventorylist_refine[.@i] +" "+ getitemname(@inventorylist_id[.@i])+ " (x"+ .@card +" Cards):"; .@index[getarraysize(.@index)] = .@i; } } .@menu$ = .@menu$ +"Cancel"; .@s = select(.@menu$)-1; if (.@s == getarraysize(.@index)) close; .@i = .@index[.@s]; mes "Are you sure you want to trade +"+ @inventorylist_refine[.@i] +" "+ getitemname(@inventorylist_id[.@i]) +" to +"+ @inventorylist_refine[.@i] +" "+ getitemname(2249) +"?"; next; if (select("Yes:No") == 2) close; delitem2 @inventorylist_id[.@i], 1, 1, @inventorylist_refine[.@i], @inventorylist_attribute[.@i], @inventorylist_card1[.@i], @inventorylist_card2[.@i], @inventorylist_card3[.@i], @inventorylist_card4[.@i]; getitem2 2249,1,1,@inventorylist_refine[.@i],0,0,0,0,0; close; }

I guess you need to change .@refine$ into .@refine to get rid off of the error

Much better if you use getitem2
new_1-1,56,126,0    script    Test    4W_SAILOR,{     if ( !countitem( 5172 ) ) close;     getinventorylist;     mes "Pick the refine rate of " + getitemname( 5172 ) + " that you want to trade...";     next;     for ( .@i = 0; .@i < @inventorylist_count; .@i++ ) {         if ( @inventorylist_id[ .@i ] == 5172 )             .@refine$[ getarraysize( .@refine$ ) ] = @inventorylist_refine[ .@i ];     }     .@s = select( implode( .@refine$, ":" ) ) - 1;     mes "Are you sure you want to trade +" + .@refine$[ .@s ] + " " + getitemname( 5172 ) + " to +" + .@refine$[ .@s ] + " " + getitemname( 2249 ) + "?";     next;     if ( select( "Yes:No" ) - 1 ) close;     delitem2 5172,1,1,.@refine$[ .@s ],0,0,0,0,0;     getitem2 2249,1,1,.@refine$[ .@s ],0,0,0,0,0;     close; }  

My Free Times comes too late :(
Anyways, Here it is: https://github.com/dastgir/HPM-Plugins/blob/master/src/plugins/CharmSystem.c

Check this:

http://herc.ws/board/topic/12231-guide-how-to-add-items-to-bnogemstone/

There's no npc like that in official, you need to manually check all your additions(or maybe someone added it in some other files to trouble you xD)

did you try using the "Use Custom Aura Limits" patch?

Highly unrecommended to  remove those warnings.
As in future, those case-sentitive checks may not be optional, and completely break your script.
 
src/map/script.h
 
#define ENABLE_CASE_CHECK   you can comment it.

Why don't you make this dungeon a custom instance for people so you don't have to worry about the monsters being killed off and reset?

Send me the script and I'll make a partyable/soloable Custom Instance dungeon for you based off the script.

@@Helena

Add me on Skype: itzmichaelmorici

@@Dastgir might be able to update it for us if he got any free time   

No way to move it...

@@Helena I was using 50, not sure if it needs to be that high. 

@@Helena If the error message about event queue is being shown on you console, then probably yes. I believe it happens with any monster that trigger labels. cause there'll be too many events to be triggered at once

@@Helena yeah divide it to 10 like garr said

Why don't you just divide the weight by 10
mes "Weight: "+(.@weight[.@i]/10); ?

Here is a rather disgusting, but quick fix for those having problems with the support tickets module. Don't forget to backup your files before applying the following fixes.
 
Fix department list items appearing twice :
addons/support/modules/support/department.php
change :
<?php if (count($all_dep_res)): ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?= (int) $row->id ?>'><?= htmlspecialchars($row->name) ?></option> <?php endforeach ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?php echo (int) $row->id ?>'><?php echo htmlspecialchars($row->name) ?></option> <?php endforeach ?><?php endif ?>  
to :
<?php if (count($all_dep_res)): ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?php echo (int) $row->id ?>'><?php echo htmlspecialchars($row->name) ?></option> <?php endforeach ?><?php endif ?>  
Fix addons/support/themes/defalut/support/list.php and addons/support/themes/defalut/support/view.php (Quick and dirty workaround for Flux::Config("ThemeName") not working with add-ons.
lib/Flux.php
change :
public static function config($key, $value = null, $options = array()){ if (!is_null($value)) { return self::$appConfig->set($key, $value, $options); } else { return self::$appConfig->get($key); }}  
to :
public static function config($key, $value = null, $options = array()){ if (!is_null($value)) { return self::$appConfig->set($key, $value, $options); } // Disgusting hardcoded fix for Flux::Config("ThemeName") in addons else if ($key == "ThemeName") { return Flux::$sessionData->theme; } else { return self::$appConfig->get($key); }} This fix is far from being satsfying because it's hardcoded and the issue will repeat with every application parameter passed as an array like ThemeName. I am not that good with PHP and I have actually no idea how to fix this without diving into the core of FluxCP. I'll edit my post if I come up with a better solution though.
 
 
06.08.2015 Edit :
I found another error in the support module and a way to fix it in the addon code (even though I suspect the problem comes from FluxCP itself ). The error (Trying to get property of non-object in [...]function.php line 306) happens when you try to log in with a wrong username/password. I didn't realize the problem until I turned debug mode on when I started working on an addon.
 
addons/support/modules/support/functions.php
change :
$group_col = getGroupCol($server); to :
$group_col = getGroupCol($session->loginAthenaGroup);  
06.14.2015 Edit :
Yet another bug, yet another ugly fix for support addon. This fixes the query errors in the ticket list pages happening depending on the current user AccountLevel.
 
addons/support/modules/list.php
change:
if ($sth->rowCount()){ $i = 0; foreach ($group_res as $row) { if ($i != 0) $sql .=" AND"; $sqlpartial .= " department != ?"; $bind[] = $row->id; $i++; }}  
to:
if ($sth->rowCount()){ $sqlpartial = "WHERE"; $i = 0; foreach ($group_res as $row) { if ($i != 0) { $sqlpartial .=" AND"; } $sqlpartial .= " department != ?"; $bind[] = $row->id; $i++; }}  
06.16.2015 Edit : Another one. Fix the error when clicking on a ticket to see the detail :
addons/support/modules/support/view.php
change :
$mail = new Flux_Mailer(); to:
$mail = @new Flux_Mailer(); Same fix applies to any other page affected by the issue.
 
Hope this helps! Also don't hesitate to correct me if you find a more proper (I know there are some) way to fix those issues! ^^

Here you go:
 
prontera,150,150,1   script   PutBack   987,{  mes "Hi. Can i help you?";  if(select("Put coins back to CP:Close") == 2) close;  if (countitem(677) < 100){    mes "I'm sorry, you need at least 100 coins because 100 is equal to 1 credit.";    close;  }    mes "Input amount:";  input .@a,100,1000;  if(.@a%100) {    mes "Can't transfer that much";    mes "Because your amount of coins ins't dividable by 100";    close;  }    if(countitem(677) < .@a) {    mes "You don't have enough "+getitemname(677);    mes "You need "+(.@a - countitem(677))+" more "+getitemname(677);    close;  }    next;  .@cp_credits = .@a/100;  mes "Here you go!";  mes "You will get "+.@cp_credits;    query_sql("UPDATE `cp_credits` SET `balance` = `balance` + "+ .@cp_credits +" WHERE `account_id` = '"+getcharid(3)+"'");  delitem 677, .@a;  close;}  
Didn't test it btw.

just use this