Trouble understanding hooking skill methods

[Trouble understanding hooking skill methods]

Well, in pre hooks it is a necessity, not an option. AnnieRuru's plugin is outdated for the latest revision of Hercules.

For an updated example check - https://github.com/Smokexyz/HerculesBG/blob/master/src/plugins/hBG.c#L3265

[Trouble understanding hooking skill methods]

In pre hooks you're working with pointers added to each argument, i.e.

 

int skill_castend_nodamage_id_pre(struct block_list **src, struct block_list **bl, uint16 *skill_id, uint16 *skill_lv, int64 *tick, int *flag)
{ (*src)->id; (*bl)->id; }

[hBG.c and HPMHooking.h Errors]

[hBG.c and HPMHooking.h Errors]

If you have a server running with many custom edits, copying all files over it would basically remove the edits. Best to checkout the latest revision of hercules in a new directory and then add Hercules BG.

[hBG.c and HPMHooking.h Errors]

That would be a bad idea.

[hBG.c and HPMHooking.h Errors]

It's best to get the latest revision of Hercules and try. I don't think HPM is fully implemented in your revision, I'm guessing it's a year or two old.

[hBG.c and HPMHooking.h Errors]

Hi, on what revision is your Hercules?

[Hercules Battlegrounds]

Should be fixed in latest commit.

[Hercules Battlegrounds]

Dual Ip checking is not functional yet.

[Hercules Battlegrounds]

Commit e5a262f9178f6425808fa8b1ecdb70c92627a9f7

Added support for @reportafk.

Also fixed an issue where idle time was not updating on bg start.

Cleanup of some bg_common.txt.

[Hercules Battlegrounds]

Fixed in latest commit.

[Hercules Battlegrounds]

Sure, I don't see why official BGs can't be converted to HBG. By changing the script commands the official script uses to HBG commands, although for this project I won't be doing this.

But feel free to donate any such implementations to my repository.

[Hercules Battlegrounds]

Problem AFK continues and News. #2

 

https://github.com/Smokexyz/HerculesBG/issues?q=is%3Aopen+is%3Aissue

 

@edit

 

@Smokexyz 

 

Would it be possible to add the official Ragnarok BGs to Hercules-BG-eAmod mode?

Have you checked out and compiled the latest revision?

[Hercules Battlegrounds]

Commit 40d08d2f8eac2387416a9f4be68b60d7cad7d7be

Improvements in the way BGs are exited, guild information is refreshed.

Removal of BG Skulls on exiting the BG.

Initial implementation of BG stats. @TODO saving to database.

Addition of @bgstart/stop commands for GMs to start and stop battlegrounds. (Credits to Vykimo and Michi for the idea.)

Initial implementation of BG rankings.

[Hercules Battlegrounds]

 

 

Added 2 commits:

 

1) Added maps.conf

Added map_index.txt

Added mob_avail.txt

Added quest_db.conf

Implemented guild skills to be shown but not usable yet.

Corrected logout cleanup functions.

Cleanup of some queue to team building functions.

 

2) Team balance Improvements

Working guild skills in BGs with less than 3 teams.

More code optimization.

 

This should most probably get us into a somewhat stable state without crashes, so we can start completing the features.

Updated original post.

 

Error and warnings to compile.

 

Warning	1	warning C4138: '*/' found outside of comment	Hercules-master\src\plugins\hBG.c	166	1	hBG
Warning	2	warning C4138: '*/' found outside of comment	Hercules-master\src\plugins\hBG.c	167	1	hBG
Warning	3	warning C4138: '*/' found outside of comment	Hercules-master\src\plugins\hBG.c	169	1	hBG
Warning	4	warning C4018: '<' : signed/unsigned mismatch	Hercules-master\src\plugins\hBG.c	873	1	hBG
Warning	5	warning C4018: '>=' : signed/unsigned mismatch	Hercules-master\src\plugins\hBG.c	1953	1	hBG
Warning	6	warning C4018: '<' : signed/unsigned mismatch	Hercules-master\src\plugins\hBG.c	2008	1	hBG
Error	7	error C2143: syntax error : missing ';' before 'type'	Hercules-master\src\plugins\hBG.c	2014	1	hBG
Error	8	error C2065: 'i' : undeclared identifier	Hercules-master\src\plugins\hBG.c	2015	1	hBG
Error	9	error C2065: 'i' : undeclared identifier	Hercules-master\src\plugins\hBG.c	2016	1	hBG
Error	10	error C2143: syntax error : missing ';' before 'type'	Hercules-master\src\plugins\hBG.c	2034	1	hBG
Error	11	error C2143: syntax error : missing ';' before 'type'	Hercules-master\src\plugins\hBG.c	2035	1	hBG
Error	12	error C2065: 'i' : undeclared identifier	Hercules-master\src\plugins\hBG.c	2037	1	hBG
Error	13	error C2065: 'i' : undeclared identifier	Hercules-master\src\plugins\hBG.c	2038	1	hBG
Error	14	error C2065: 'pos' : undeclared identifier	Hercules-master\src\plugins\hBG.c	2041	1	hBG
Error	15	error C2065: 'i' : undeclared identifier	Hercules-master\src\plugins\hBG.c	2041	1	hBG
Error	16	error C2065: 'qm' : undeclared identifier	Hercules-master\src\plugins\hBG.c	2043	1	hBG
Error	17	error C2065: 'pos' : undeclared identifier	Hercules-master\src\plugins\hBG.c	2043	1	hBG
Warning	18	warning C4047: '=' : 'int' differs in levels of indirection from 'hBG_queue_member *' Hercules-master\src\plugins\hBG.c	2043	1	hBG
Warning	19	warning C4047: '==' : 'int' differs in levels of indirection from 'void *' Hercules-master\src\plugins\hBG.c 2043 1 hBG
Error	20	error C2223: left of '->sd' must point to struct/union	Hercules-master\src\plugins\hBG.c	2043	1	hBG
Warning	21	warning C4018: '<' : signed/unsigned mismatch	Hercules-master\src\plugins\hBG.c	2125	1	hBG
Warning	22	warning C4090: 'function' : different 'const' qualifiers	Hercules-master\src\plugins\hBG.c	2913	1	hBG

I've pushed 2 more commits eliminating the warnings, I don't have an issue with compiling other than 3 normal warnings regarding unused variables and casts discarding constant qualifiers.

What compiler are you using?

[Hercules Battlegrounds]

Added 2 commits:

 

1) Added maps.conf
Added map_index.txt

Added mob_avail.txt
Added quest_db.conf
Implemented guild skills to be shown but not usable yet.
Corrected logout cleanup functions.
Cleanup of some queue to team building functions.

 

2) Team balance Improvements

Working guild skills in BGs with less than 3 teams.

More code optimization.

 

This should most probably get us into a somewhat stable state without crashes, so we can start completing the features.

Updated original post.

[Hercules Battlegrounds]

 

Added all client side files from : https://github.com/zephyrus-cr/eamod/tree/master/ClientSide

 

And the maps?

The maps are duplicates. mapcache.exe duplicates the maps when you use the contents in resnametable.txt.

[Hercules Battlegrounds]

Added all client side files from : https://github.com/zephyrus-cr/eamod/tree/master/ClientSide

[Hercules Battlegrounds]

Hercules Battlegrounds

A full conversion and enhancement of eAmod's Battlegrounds system into a easy-to-install Hercules plugin library.

Version: 1.0a (alpha)

 

 

Repository @ https://github.com/Smokexyz/HerculesBG

Installation
1) Place plugin files in plugin directory. (If you wish to re-compile the code, please do so the standard way.)
2) Place all script files in the default directory provided in the repository (or your own).
3) Place all database and config parts in their respective files.
4) in conf/plugins.conf add "hBG".

 

Instructions on installing Plugins - http://herc.ws/wiki/HPM#Building_a_plugin

 

Battleground Modes

• Capture the Flag
• Eye of Storm
• Triple Inferno
• Team DeathMatch
• Bossnia
• Conquest
• Stone Control
• Domination
• Rush
• Free For All

Why use it?
1) Prevents conflicts when updating Hercules.
2) Easy to install.
3) Can be easily modified for more functions/features in the future.

For contributors
If you wish to add a free BG script to the list of available battleground modes, please contact me.

 

Bug Reporting

Please feel free to open an issue on the repository and I'll get to it as soon as I can.

Donate to support the project and motivate updates.

[Capping Aspd, possible to increase through quest.]

It is, with some source mod.

[How to make countitem not counting equip equipments]

It's not possible to delete an item from the inventory only. Delitem does not support arguments for inventory index, even though it should. If you want a source mod for it I can help.

[Custom @command]

Why can't this be added to the source of Hercules rather than a plugin. Reasons - 

1) @commands are a custom feature.

2) Bindatcmd is a custom feature.

3) without this Bindatcmd seems incomplete.

[DB error - Data truncated zenylog]

This should be fixed with - https://github.com/HerculesWS/Hercules/pull/1491

[[ Error ] : pc_checkskill: Invalid skill]

You can post an issue in the issue tracker for this, make sure you tag the revision number you're using and some more logs of the console would really help in finding the cause.

[I need help in this code !!!]