Jump to content
  • Sign Up

Sephus

Core Developers
 View Profile  See their activity

  • Content Count

    235

  • Joined

  • Last visited

  • Days Won

    47

Posts posted by Sephus

  2. Posted

    Wouldn't be

     

    setequipoption(<equip_index>,<opt_index>,<slot>,<value>);

     

    Instead of

     

    setequipoption(<equip_index>,<slot>,<opt_index>,<value>);

     

    ?

     

    The Item Option NPC released has the variables inverted in the method call too.

    Yes, this will be fixed soon. The correct order is setequipoption(<equip_index>,<slot>,<opt_index>,<value>);

     

    Edit: Fixed in the latest commit.

     

     

    Also, I found a possible exploit:

    Using the NPC to put options on an item, if you put an option the NPC will unequip the item, but if the item has options values already, the bonuses will stay with the character even without the equipment.

    Removing the equipment manually removes the bonus, its just the "autoremove" from setequipoption that doesn't.

    Addressed in PR#1673 Thank you for the report.

    tedexx and Legend reacted to this

  3. Posted

    So with the release of Item Options System I had created a demo NPC with a small number of options to test the system out or be used as a full fledged NPC.

     

    Configuration

    	/**
	 * General Configuration
	 */
	/* Chance of the enhancement process to fail. (0 - 99 in percent) */
	.chance_of_failure = 10;
	/* Delete the item on failure? (true/false) */
	.delete_on_failure = true;
	/* Required amount of zeny for a try. */
	.zeny_requirement = 100;
	/* Minimum amount of the bonus value. 
	 * For negative effects or certain bonuses that require negative values
	 * Maximum possible value is -INT16_MAX)
	 */
	.minimum_bonus_amount = -100; // usually used with delay bonus options, although not provided in the script.
	/* Maximum amount of the bonus value. 
	 * Maximum possible value is INT16_MAX */
	.maximum_bonus_amount = 100;
	/* Disable selection of bonus value (true/false) */
	.enable_random_bonus = false;
	
	/* Item Option Descriptions */
	setarray(.options$[0], "Max HP", "Max SP", "STR", "AGI", "VIT", "INT", "DEX", "LUK");
	/* Item Option Constants */
	setarray(.option_constants[0], VAR_MAXHPAMOUNT, VAR_MAXSPAMOUNT, VAR_STRAMOUNT, VAR_AGIAMOUNT, VAR_VITAMOUNT, VAR_INTAMOUNT, VAR_DEXAMOUNT, VAR_LUKAMOUNT);
	end;

     

    File v1.0

    item_options.txt 

     

    Let me know what you think!

     

    Enjoy~! :)

    Legend, dnote98, Radian and 1 other reacted to this

  4. Posted

    Introducing the Item Options System!

     

    k3TrEvc.png

     

    Commit

    https://github.com/HerculesWS/Hercules/commit/974222a8d3f189083205bf5d330de04a43226ad3

     

    Feature Information

    The Item Option System is a feature that was implemented in 2015-02-26 clients, allowing equipments to have up to 5 additional effects similar to cards or enchants. Each equipment is capable of having 5 information bars above the card slot/enchant bar that describes the effect of the option it is infused with.

     

    New Script Commands (The following snippet is available in doc/script_commands.txt.)

    *getequipisenableopt(<equipment slot>)

This function checks if the equipped item allows the use of bonus options.

Returns 1 if allowed, 0 if not.

---------------------------------------

*getequippedoptioninfo(<info_type>);

This function is to be used with the scripts of contents listed in
db/item_options.conf only.

Returns the value of the current equipment being parsed.
If the equip was not found or the type is invalid, -1 is returned.

---------------------------------------

*getequipoptioninfo(<equip_index>,<slot>,<type>);

Gets the option information of an equipment.

<equipment_index> For a list of equipment indexes see getequipid().
<option_slot> can range from 1 to MAX_ITEM_OPTIONS
<type> can be IT_OPT_INDEX (the ID of the option bonus, @see "Id" or "Name" in db/item_options.conf)       or IT_OPT_VALUE (the value of the bonus script of the equipment, @see "Script" in db_item_options.conf).

returns the value of the slot if exists or -1 for invalid slot, type or slots.

---------------------------------------

*setequipoption(<equip_index>,<slot>,<opt_index>,<value>);

Set an equipment's option index or value for the specified option slot.

<equipment_index> For a list of equipment indexes see getequipid().
<option_slot> can range from 1 to MAX_ITEM_OPTIONS
<type> can be IT_OPT_INDEX (the ID of the option bonus, @see "Id" or "Name" in db/item_options.conf)
<value> The value of the type to be set.

returns 0 if value couldn't be set, 1 on success.

     

     

    Release Notes

    • This system allows the infusing of equipments with bonus item options.
    • This feature is constrained to clients of packet versions greater than or equal to 20150226.
    • Item Options and their effects are defined server-side in db/item_options.conf and client side in data/luafiles514/lua files/datainfo/addrandomoptionnametable.lub
    • The ID of the option must tally with the correct index of the description provided in the client side file.
    • IT_OPT_* keys and MAX_ITEM_OPTIONS macro are also exported from the source as constants.
    • If you wish to disable item options for certain (equipment) items, an additional flag `disable_options` has been added to the item sql tables, and as `DisableOptions: true/false (boolean, defaults to false !!for equipments only!!)` to the item_db.conf files.
    • Documentation is provided for script commands.
    • If upgrading, don't forget to run the sql upgrade files!


    Credits

    A big thanks to all the reviewers that helped make the code closer to perfection. -

    Emistry, dastgir, MishimaHaruna, Jedzkie, Ridley8819, Asheraf, 4144.

     

    Style and Script Fixes by Asheraf (https://github.com/Asheraf)
    Initial design Idea in rAthena commit.

    Legend, Arduino, Murilo BiO' and 12 others reacted to this

  9. Posted

    Hey all,

     

    So I've worked on a difference checker between the fields of some rAthena and Hercules database files.

    This could help people or devs or users do quick lookups for differences.

     

    Key Features

    The differences are listed in libconfig format to make things easier for people trying to merge or lookup entries between rAthena and Hercules.

    It lists only the differences if any. (Except ID and Name field for quick lookups).

     

    Repository: https://github.com/Smokexyz/Hercules-vs-rAthena

     

    Currently supported files -

    • db/pre-re/mob_db.conf
    • db/pre-re/item_db.conf
    • db/pre-re/skill_db.conf
    • db/re/mob_db.conf
    • db/re/item_db.conf
    • db/re/skill_db.conf

     

    TODO

    1. Add support for more files.
    2. Automate checks and updates to repository.

     

    If you have any suggestions for files or format do let me know.

    If you want to report errors, please feel free to open an issue on the repository page.

    aszrool, cfelten, Legend and 3 others reacted to this

  11. Posted

    https://github.com/S...c5f5bc994d174a2

     

    Release of Hercules Battlegrounds 1.0a (alpha)

    - Added base support for battleground statistics (including sql).
    - Completed configurations file and settings.
    - Fixed crashing of map on player logout. (Thanks to those that reported).
    - Cleanup of several code-blocks, optimization and code-styling.
    - Fixed errors thrown by exceeding def/mdef values for pre-re configuration.
    - Fixed data store type mismatch error. (Thanks to those that reported).
    This is the initial alpha and stable release of the Hercules Battlegrounds plugin.
     
    Topic updated.
    Documentation has been moved to the readme section of the repository.
    Thank you to those that tested and submitted core dumps.
    caspe and tedexx reacted to this

  14. Posted

     

     

    What do I need to become a developer of the Hercules Staff and try to put this project forward?

    you may check the guidelines and criteria here - http://herc.ws/board/contactus/

     

    Do I need to fix some emulator bug to apply for the Development spot? Is there a specific number of fixes?

    Yes you do (for developer positions). There is no fixed number, just go about making fixes and submit your application for the team to decide whether you're suitable or not for the position.

    Fou-lu reacted to this

  24. Posted

    If you're trying to use a later client, I would recommend 20150513. It seems to be the most stable. Make sure your packet keys are correct or disable the obfuscation check altogether. Either way, a basic hercules setup takes nothing more than 10 minutes if you have the client ready (the client, a working data folder to compliment it and dastgir+michieru's translations from their repo - That's it).

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept