AnnieRuru

update to version 1.3 plugin consumables should be done with *sc_start something { Id: 32247 AegisName: "Dark_Elf_Potion" Name: "Dark Elf Potion" Type: "IT_USABLE" Weight: 100 BuyingStore: true Trade: { nodrop: true noselltonpc: true nomail: true noauction: true } Script: <" sc_start SC_INCDEX, 500, 10; sc_start SC_INCINT, 500, 20; sc_start SC_INCAGI, 500, 5; sc_start SC_INCMATKRATE, 500, 10; "> }, seems unrelated to what this modification does ... though

prontera,155,185,5 script kjdshfkdjsf 1_F_MARIA,{ // addjobskill = 0; mes "select the type of skills you want to learn"; next; addjobskill = select( "swordsman", "mage", "acolyte" ); mes "your skills will be added the next time you adjust your equipment !"; close2; recalculatestat; end; OnPCStatCalcEvent: switch ( addjobskill ) { case 1: skill "SM_BASH", 10; skill "SM_PROVOKE", 10; skill "SM_MAGNUM", 10; break; case 2: skill "MG_FIREBOLT", 10; skill "MG_LIGHTNINGBOLT", 10; skill "MG_COLDBOLT", 10; break; case 3: skill "AL_HEAL", 10; skill "AL_INCAGI", 10; skill "AL_BLESSING", 10; break; default: } } please elaborate the term "not working" I tried make a video about it and it cost 500MB, but my slow internet says need to upload this in 3 hours so I give up the idea uploading this to youtube if somebody reply this isn't work, then I'll try to squeeze some of my internet quota to upload a video as a proof

too little info, upon reading the source code, gm commands "@kami" and script commands *announce use clif->broadcast which can be easily hijack this function but some of them *mapannounce *areaannounce do stuffs like map->foreachinmap which need to edit each function respectively <--which can be alot of work and some broadcast shouldn't be disable like 1. "WoE has started !!" 2. "XXX Event going to start in x minutes !!" 3. "Player A has pawn player B on map X" <-- pvp ladder announcement 4. instance map announce like endless tower announcing MVP going to spawn in fact, I think you need to list out all the things that CAN be disable for the player and some things that CAN'T disable for the player otherwise player start complaining after they enable "@nobc" then they didn't hear any announcement from events or instance for example &1 can disable player's megaphone &2 disable pvp announcement &4 disable gm's "@kami" announcement &8 disable event going to start and during event progress announcement &16 disable server changing rate announcement - double drop rate has started &32 disable instance announcement, disable mvp going to spawn in the instance etc &64 disable woe announcement, "Guild X has conquered X map!!" I hope you get what I mean when I see the scope of this script, it can be different from server to server, so be more specific when you try to elaborate the idea so what are you talking about ? only disable players' megaphone ? if that's the only thing you want that is pretty easy to do why not just tell the player to sell the item to the npc ? if the item is bound (through *getbounditem script command) you can use item deleter script on the forum it was made because some player complain that item crash their client, so a text based script (pull from my getitemname2 function) so player can go to the npc to delete the item .... if you open 3 topics then I can search it for you (PS: I think I lost that script, it was made on eathena forum if I'm still remember) this one is straight forward, no problem for this one AND !!!!! Please make 1 request per topic you should open 3 topics for each one command requested I'm sorry I'm going to lock this topic because of your low effort in describing your idea

@evilpuncker there you go Download: plugin tested with prontera,155,185,5 script dfgsfgdfg 1_F_MARIA,{ pet 0; } //prontera mapflag nopettame there are several problems with this plugin though 1. I tested with unripe apple, and the item still being deleted, because it seems hercules has changed pet taming items from IT_DELAYCONSUME(11) into IT_USABLE(2) 2. Sage's hocus pocus has SA_TAMINGMONSTER skill also can catch pets, so nope, I couldn't just give back the items, since give back items also mean sage will get free pet taming items DISCUSSION !!! lazy to think anymore .... go to sleep now brrrr...

trying to integrate this script with HULD, but I couldn't get it to work, so drop the idea update hercules version to 1.3 script plugin I'll assume rathena still works in version 1.2, as I just tested it still working fine and for all those members saying how to patch

@Zero Human can you please tell me which compiler you use to get that error ? I tested on latest hercules with Visual Studio 2019 and it doesn't throw any error and..... this plugin still works, but has to extra step by adding a diff after this commit src/common/mmo.h | 2 +- src/map/skill.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/mmo.h b/src/common/mmo.h index e4b5a8bd5..6d029228a 100644 --- a/src/common/mmo.h +++ b/src/common/mmo.h @@ -234,7 +234,7 @@ #define MAX_CART 100 #endif #ifndef MAX_SKILL_DB -#define MAX_SKILL_DB 1314 ///< Maximum number of skills in the skill DB (compacted array size) +#define MAX_SKILL_DB 1318 ///< Maximum number of skills in the skill DB (compacted array size) #endif #ifndef MAX_SKILL_ID #define MAX_SKILL_ID 10015 // [Ind/Hercules] max used skill ID diff --git a/src/map/skill.c b/src/map/skill.c index c2a336d7e..f827eb21f 100644 --- a/src/map/skill.c +++ b/src/map/skill.c @@ -97,6 +97,7 @@ static const struct { { HLIF_HEAL, MH_VOLCANIC_ASH }, { MS_BASH, MER_INVINCIBLEOFF2 }, { EL_CIRCLE_OF_FIRE, EL_STONE_RAIN }, + { 2991, 2994 }, { GD_APPROVAL, GD_DEVELOPMENT }, CUSTOM_SKILL_RANGES }; blame 4144 and dastgir adding custom skills even harder now https://github.com/HerculesWS/Hercules/pull/2596 I dunno how to fix this just by plugin alone ... honestly someone please show me the way to add custom skill by just plugin alone ( example the extra *bonus can be added via plugin ) not like 4144 said need to add new custom project setting blah blah blah

https://github.com/AnnieRuru/Release/blob/master/scripts/Quest %26 Shops/card_seller/card_seller_0.3.txt use previous version 

what error does it appear on your map-server ? https://github.com/AnnieRuru/Release/blob/master/scripts/Quest %26 Shops/card_seller/card_seller_0.3.txt use previous version I released the zeny version first, then members ask me how to use token item to buy... then I post this release by trading with item token, then members ask me back how to use zeny ... WTF

Guide: How to post anonymously on the Internet 1. open incognito tab 2. login into your account 3. profit !! now you can anonymously on the Internet PS: nobody knows its me ... right ? I post this in incognito mode ~

// Build the Menu. setarray .@costume, EQI_COSTUME_HEAD_TOP, EQI_COSTUME_HEAD_MID, EQI_COSTUME_HEAD_LOW, EQI_COSTUME_GARMENT; .@menu$ = ""; for (.@i = 0; .@i < getarraysize(.@costume); ++.@i) .@menu$ += ((getequipisequiped(.@costume[.@i])) ? getequipname(.@costume[.@i]) : "" + .@costume[.@i] + "-[Not equipped]") + ":"; // Select the part. .@equip_index = .@costume[ select(.@menu$) -1 ];

I also don't understand what your question is you claimed the script doesn't work, but I just tested it working fine .... of course only for the non-costume equipment // Build the Menu. setarray(.@position$[1], "Head", "Body", "Left Hand", "Right Hand", "Robe", "Shoes", "Accessory 1", "Accessory 2", "Head 2", "Head 3"); .@menu$ = ""; for (.@i = 1; .@i <= 10; ++.@i) .@menu$ += ((getequipisequiped(.@i)) ? getequipname(.@i) : .@position$[.@i] + "-[Not equipped]") + ":"; // Select the part. .@equip_index = select(.@menu$); if you want to extend to costume area, this part has to modify

....WindowsSDK.targets(46,5) : error [CUT OFF] try copy paste the lines by Ctrl+C and Ctrl+V over here and google is your best friend to ask anything wtf ... this stupid visual studio installer ... every time I double click it, it ask for update ...

should be 15, that guide .... might be wrong ... after all, MSVC 2017 is version 15 https://en.wikipedia.org/wiki/Microsoft_Visual_Studio#History need to update that guide

I think its official, otherwise there are 2 places to check it doesn't trigger on boss

you should also tell you are using windows or linux, as the method are entirely different http://herc.ws/wiki/Building_HPM_Plugin_for_MSVC. https://github.com/HerculesWS/Hercules/wiki/Building-HPM-Plugin-for-MSVC https://github.com/HerculesWS/Hercules/wiki/Building-HPM-Plugin-for-gcc

prontera,155,185,5 script kjhdsfks 1_F_MARIA,{ detachrid; .@total = getunits( BL_PC, .@aid, false ); for ( .@i = 0; .@i < .@total; ++.@i ) { attachrid .@aid[.@i]; soundeffect "ownage.wav", 0; } end; }

not working I equip a 'Secular_Mission' ItemID 2127, and expecting it to list all as 25, prontera,155,185,5 script kjhdsfks 1_F_MARIA,{ for ( .@i = RC_Formless; .@i <= RC_Player; ++.@i ) dispbottom race_resist(.@i) +""; end; } but it display all in 0 instead a few places are wrong in your plugin, but are actually correct in wolfie's version 1. the constant case-sensitivity wolfie's constants are correct, but yours are wrong should follow the constants.md file, not the source file https://github.com/HerculesWS/Hercules/blob/stable/doc/constants.md#elements ### Elements - `Ele_Neutral`: 0 - `Ele_Water`: 1 - `Ele_Earth`: 2 - `Ele_Fire`: 3 - `Ele_Wind`: 4 - `Ele_Poison`: 5 - `Ele_Holy`: 6 - `Ele_Dark`: 7 - `Ele_Ghost`: 8 - `Ele_Undead`: 9 - `Ele_All`: 255 ### Races - `RC_Formless`: 0 - `RC_Undead`: 1 - `RC_Brute`: 2 - `RC_Plant`: 3 - `RC_Insect`: 4 - `RC_Fish`: 5 - `RC_Demon`: 6 - `RC_DemiHuman`: 7 - `RC_Angel`: 8 - `RC_Dragon`: 9 - `RC_Player`: 10 - `RC_Boss`: 11 - `RC_NonBoss`: 12 - `RC_NonDemiHuman`: 14 - `RC_NonPlayer`: 15 - `RC_DemiPlayer`: 16 - `RC_NonDemiPlayer`: 17 - `RC_All`: 255 2. your plugin stop at RC_Player, which is 10, but I tested with 'Secular_Mission' which has Script: <" bonus2 bSubRace, RC_All, 25; "> RC_ALL is 255 ... lol

even this is old topic, but this member still active unfortunately not all stuffs can be turn into plugin, like adding custom cell_ type (setcell) ... etc.. but, plugin do provide function overload, which is kinda a double-edge-sword you can overload the function with a plugin file, but you still have to update this plugin file periodically to prevent it from not working also having 2 plugins overload the same function, defeats the purpose of using plugin so for your answer, there is no other choice but to copy paste the skill_additional_effect function into the plugin, with the lines you wish to edit https://github.com/HerculesWS/Hercules/wiki/Hercules-Plugin-Manager#hpm-function-overloading

1.8 - plugin - update to latest revision

this has nothing to do with stylist script, nor the showscript script command, but rather the *setquestinfo script command and I reproduce the problem with this topic, so move the post over here https://github.com/HerculesWS/Hercules/issues/2431 and also can only reproduce with "@reloadscript" so it isn't ... too severe I guess, because live server shouldn't use "@reloadscript" at all

1.6 - script - now the styles display number no longer shown to other players https://github.com/HerculesWS/Hercules/wiki/Adding-a-Script#adding-and-activating-scripts

I found Hercules members using Pre-Renewal server ... mostly yes you can use newer client for Pre-RE server btw, I rolled back to 20180621 client at this moment because I think newer client are not so stable to use in live server

no idea, I have tested it works do I seriously have to do like this ? https://github.com/HerculesWS/Hercules/compare/master...AnnieRuru:topic/16676-n. https://github.com/AnnieRuru/Hercules/blob/803f7335803460b8a4f2554240a9b29f4686f556/src/map/battle.c#L4957-L4963

@@ -4960,6 +4953,14 @@ static struct Damage battle_calc_weapon_attack(struct block_list *src, struct bl the patch has clearly said, modify the line somewhere at line no.4960 and your compiler said your error is on line 4127

if you change skill->attack from BF_MISC into BF_WEAPON, then you should also change the damage calculation from battle_calc_misc_attack function into battle_calc_weapon_attack function src/map/battle.c | 15 ++++++++------- src/map/skill.c | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/map/battle.c b/src/map/battle.c index 1b7bf909e..4193c8cd0 100644 --- a/src/map/battle.c +++ b/src/map/battle.c @@ -4130,13 +4130,6 @@ static struct Damage battle_calc_misc_attack(struct block_list *src, struct bloc case NPC_EVILLAND: md.damage = skill->calc_heal(src,target,skill_id,skill_lv,false); break; - case RK_DRAGONBREATH: - case RK_DRAGONBREATH_WATER: - md.damage = ((status_get_hp(src) / 50) + (status_get_max_sp(src) / 4)) * skill_lv; - RE_LVL_MDMOD(150); - if (sd) md.damage = md.damage * (95 + 5 * pc->checkskill(sd,RK_DRAGONTRAINING)) / 100; - md.flag |= BF_LONG|BF_WEAPON; - break; /** * Ranger **/ @@ -4960,6 +4953,14 @@ static struct Damage battle_calc_weapon_attack(struct block_list *src, struct bl break; } break; + + case RK_DRAGONBREATH: + case RK_DRAGONBREATH_WATER: + wd.damage = ((status_get_hp(src) / 50) + (status_get_max_sp(src) / 4)) * skill_lv; + wd.damage = wd.damage * status->get_lv(src) / 150; + if (sd) wd.damage = wd.damage * (95 + 5 * pc->checkskill(sd,RK_DRAGONTRAINING)) / 100; + wd.flag |= BF_LONG|BF_WEAPON; + break; default: { i = (flag.cri diff --git a/src/map/skill.c b/src/map/skill.c index 633a73d67..4121d66e7 100644 --- a/src/map/skill.c +++ b/src/map/skill.c @@ -4937,7 +4937,7 @@ static int skill_castend_damage_id(struct block_list *src, struct block_list *bl if( (tsc = status->get_sc(bl)) && (tsc->data[SC_HIDING] )) { clif->skill_nodamage(src,src,skill_id,skill_lv,1); } else - skill->attack(BF_MISC,src,src,bl,skill_id,skill_lv,tick,flag); + skill->attack(BF_WEAPON,src,src,bl,skill_id,skill_lv,tick,flag); } break; case NPC_SELFDESTRUCTION: { but how you want to change the damage formula is totally up to you ...