release [Release] ExtendedBG for Hercules (with eAmod BG modes)

[Daifuku 125]

@@Dastgir any EST on when it comes out?  

[Skyline 23]

10/10 my body is ready

[mleo1 36]

 

I wanna help in flux addon and in the ranking script, I know little php and scripting, for practice. just gimme leaks too, kek

 

 

>Actually i made the woestats work on Herc, vBrenth, can you send me that code for the adaptation (BG)

 

Been working on it since past 2-3 days, and Rankings are implemented completely(need to test off, but code is done)

 

kek busy, you can do it alone i think, you got the skills, and you already finished almost all of it lel,

[Skyline 23]

 

 

I wanna help in flux addon and in the ranking script, I know little php and scripting, for practice. just gimme leaks too, kek

 

 

>Actually i made the woestats work on Herc, vBrenth, can you send me that code for the adaptatio

n (BG)

 

Been working on it since past 2-3 days, and Rankings are implemented completely(need to test off, but code is done)

kek busy, you can do it alone i think, you got the skills, and you already finished almost all of it lel,

 

This is why we should throw pizza at Dastgir.

[Alexandria 53]

 

Edited February 14, 2016 by Alexandria

[Dastgir 1246]

 

*looks around me*

*hides away for a month*

[Skyline 23]

 

 

*looks around me*

*hides away for a month*

*Casts spider web on Dastgir*

[KaL EL ™ 0]

exited

[Alexandria 53]

Hello,

 

Just wondering if there is any update?

[Dastgir 1246]

Repository Link: https://github.com/dastgirp/eBG (Please read README.md for installation steps)

 

Leave Comments/Suggestions if you find something.

NOTE:

•  There might be some(/many) debug messages left in map-server which will be cleaned up.
• I will add battle.conf soon (you have to add it yourself for now or edit the plugin)
• The plugin might be a big mess to read/understand (I did many experiments over the year)
• There might be some bugs

Thanks to @Rebel and @Myriad for testing and providing initial feedback

[xVec 1]

4 hours ago, Dastgir said:

Repository Link: https://github.com/dastgirp/eBG (Please read README.md for installation steps)

 

Leave Comments/Suggestions if you find something.

NOTE:

•  There might be some(/many) debug messages left in map-server which will be cleaned up.
• I will add battle.conf soon (you have to add it yourself for now or edit the plugin)
• The plugin might be a big mess to read/understand (I did many experiments over the year)
• There might be some bugs

Thanks to @Rebel and @Myriad for testing and providing initial feedback

nice man, thanks.

Is secure to use in a production server, or still not?

[Dastgir 1246]

3 hours ago, xVec said:

nice man, thanks.

Is secure to use in a production server, or still not?

I am not yet sure, initial feedback was good, however there can be some bugs not known yet.

[bWolfie 138]

Hopefully people can help improve this in a positive way.

[astralprojection 35]

1. at line 1770 of eBG_common.c, can you check here @Dastgir

2. Some sql error: 

: DB error - Field 'score' doesn't have a default value.  This happens if i bring flag to my base.

	3. @commands not loaded.  there might be some issue on setting so it did not proceed to load other settings.

	 

(07/29/2018 10:23:11) [ Debug ] : Function: setarray (14 parameters):
(07/29/2018 10:23:11) [ Debug ] : Data: variable name='$bg_flavius_ctf' index=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=3
(07/29/2018 10:23:11) [ Debug ] : Data: number value=5
(07/29/2018 10:23:11) [ Debug ] : Data: number value=5
(07/29/2018 10:23:11) [ Debug ] : Data: number value=2000
(07/29/2018 10:23:11) [ Debug ] : Data: variable name='BF_Badge2' index=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=15
(07/29/2018 10:23:11) [ Debug ] : Data: number value=10
(07/29/2018 10:23:11) [ Debug ] : Data: number value=10
(07/29/2018 10:23:11) [ Debug ] : Data: number value=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=1
(07/29/2018 10:23:11) [ Debug ] : Source (NPC): BG_Settings (invisible/not on a map)
(07/29/2018 10:23:11) [ Warning ] : script_get_val: cannot access player variable 'BF_Badge2', defaulting to 0

 

Edited July 29, 2018 by astralprojection

[Dastgir 1246]

1 hour ago, astralprojection said:

1. at line 1770 of eBG_common.c, can you check here @Dastgir

2. Some sql error: 

: DB error - Field 'score' doesn't have a default value.  This happens if i bring flag to my base.

	3. @commands not loaded.  there might be some issue on setting so it did not proceed to load other settings.

	 

(07/29/2018 10:23:11) [ Debug ] : Function: setarray (14 parameters):
(07/29/2018 10:23:11) [ Debug ] : Data: variable name='$bg_flavius_ctf' index=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=3
(07/29/2018 10:23:11) [ Debug ] : Data: number value=5
(07/29/2018 10:23:11) [ Debug ] : Data: number value=5
(07/29/2018 10:23:11) [ Debug ] : Data: number value=2000
(07/29/2018 10:23:11) [ Debug ] : Data: variable name='BF_Badge2' index=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=15
(07/29/2018 10:23:11) [ Debug ] : Data: number value=10
(07/29/2018 10:23:11) [ Debug ] : Data: number value=10
(07/29/2018 10:23:11) [ Debug ] : Data: number value=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=0
(07/29/2018 10:23:11) [ Debug ] : Data: number value=1
(07/29/2018 10:23:11) [ Debug ] : Source (NPC): BG_Settings (invisible/not on a map)
(07/29/2018 10:23:11) [ Warning ] : script_get_val: cannot access player variable 'BF_Badge2', defaulting to 0

 

 

1/2) Would be fixed in next revision (It is recommended to use char-server save)

3) Might be right, you need to include commands in groups.conf, its available to Admins by default

4) BF_Badge2 is constant from item_db.conf, it exists on both renewal and pre-renewal. If you have disabled it, then add it back, or change to whatever you want to give.

 

(Opening issue on github would be quick, however this forum can be used for support)

[astralprojection 35]

As I tested on CTF, my original guild member was also included in my BG guild.
 

[Dastgir 1246]

1 hour ago, astralprojection said:

As I tested on CTF, my original guild member was also included in my BG guild.
 

Fixed, it was just a visual bug. (https://github.com/dastgirp/eBG/commit/080ab35cfeecca43884adc6c192d9f99f8f17364)

[astralprojection 35]

too fast.. to furious! Thanks @Dastgir

[astralprojection 35]

Can you check on this @Dastgir.  I was using the latest Herc updated today.

[Dastgir 1246]

2 hours ago, astralprojection said:

Can you check on this @Dastgir.  I was using the latest Herc updated today.

Fixed (https://github.com/dastgirp/eBG/commit/b46bec4f5c39cb19b3f25258418e17a3490ee016), it was due to https://github.com/HerculesWS/Hercules/commit/45f0fd6ba6 that was released today on stable branch.

[bWolfie 138]

Good stuff guys. Keep up reporting issues in an orderly manner.

[Dastgir 1246]

3 hours ago, Quazi said:

please check this one sir @Dastgir im using the latest hercules..

Although that's just warning(with no effect on anything), it will be fixed and pushed later today.

Edit: Should be fixed https://github.com/dastgirp/eBG/commit/9fe7a5a07a789a37be1cd5ae11edb8cb86bdaa7b

[Hidekitakase 4]

Yay, thanks sir . i'll test

[Rebel 23]

How to? Client : 2013 - 08 - 07

[Dastgir 1246]

1 hour ago, Rebel said:

How to? Client : 2013 - 08 - 07

Fixed @ https://github.com/dastgirp/eBG/commit/aaa190f69b12d7ed0941c5b9ea1645d21c3c4256

It was due to https://github.com/dastgirp/eBG/commit/098e13bb00e0ea2250b591e15f57bd89b1c67784, where I swapped some numbers too.